yuqi1129 commented on code in PR #9003:
URL: https://github.com/apache/gravitino/pull/9003#discussion_r2485156017
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/authentication/kerberos/HiveBackendProxy.java:
##########
@@ -110,11 +112,20 @@ private ClientPool<IMetaStoreClient, TException>
resetIcebergHiveClientPool()
final Field m = HiveCatalog.class.getDeclaredField("clients");
m.setAccessible(true);
- // TODO: we need to close the original client pool and thread pool, or it
will cause memory
- // leak.
- ClientPool<IMetaStoreClient, TException> newClientPool =
+ // Get and close the old client pool before replacing it
Review Comment:
Hi, I noticed that the following code will only try to close the Hive client
pool and is unable to free the thread pool in
`CachedClientPool#Cache`, can you also try to handle it? Please let me know
if there is any problem with it. In our previous attempt, it took time and
effort to close the thread pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
