sunxiaojian commented on code in PR #9003:
URL: https://github.com/apache/gravitino/pull/9003#discussion_r2485860737
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/authentication/kerberos/HiveBackendProxy.java:
##########
@@ -110,11 +112,20 @@ private ClientPool<IMetaStoreClient, TException>
resetIcebergHiveClientPool()
final Field m = HiveCatalog.class.getDeclaredField("clients");
m.setAccessible(true);
- // TODO: we need to close the original client pool and thread pool, or it
will cause memory
- // leak.
- ClientPool<IMetaStoreClient, TException> newClientPool =
+ // Get and close the old client pool before replacing it
Review Comment:
@yuqi1129 When creating a 'clientPoolCache', it uses the custom thread pool
'scheduled ExecutionService' from IcebergHiveCachedClientPool. When calling
`IcebergHiveCachedClientPool.close()', the thread pool will be directly shut
down.
https://github.com/apache/gravitino/blob/35a2dc1183ffd8dcee4b7bc6d99c8fb962720dab/iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/utils/IcebergHiveCachedClientPool.java#L143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
