yuqi1129 commented on code in PR #9003:
URL: https://github.com/apache/gravitino/pull/9003#discussion_r2488592999
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/authentication/kerberos/HiveBackendProxy.java:
##########
@@ -110,11 +112,20 @@ private ClientPool<IMetaStoreClient, TException>
resetIcebergHiveClientPool()
final Field m = HiveCatalog.class.getDeclaredField("clients");
m.setAccessible(true);
- // TODO: we need to close the original client pool and thread pool, or it
will cause memory
- // leak.
- ClientPool<IMetaStoreClient, TException> newClientPool =
+ // Get and close the old client pool before replacing it
Review Comment:
Yes, that is the exact cause that make it as the to-do item here, however,
we have clear it use refection and it's somewhat not very elegant.
please
see:https://github.com/apache/gravitino/blob/35a2dc1183ffd8dcee4b7bc6d99c8fb962720dab/catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogOperations.java#L127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
