jerryshao commented on code in PR #9016: URL: https://github.com/apache/gravitino/pull/9016#discussion_r2492748548
########## catalogs/catalog-generic-lakehouse/src/main/java/org/apache/gravitino/catalog/lakehouse/lance/LanceCatalogOperations.java: ########## Review Comment: > To be honest, the current code organization scatters the logic for table operations between `GenericLakehouseCatalogOperation` and `LanceCatalogOperation`, which reduces code readability (you need to pay attention to both code logics when operating Lance tables) and introduces some repetitive operations (such as repeatedly gettingTable from store), I think we should consider this issue in our future refactoring. I agree, the implementation is not good, it messes with different logic, and doesn't clearly separate the responsibilities. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
