yuqi1129 commented on code in PR #9016:
URL: https://github.com/apache/gravitino/pull/9016#discussion_r2492719849
##########
lance/lance-common/src/main/java/org/apache/gravitino/lance/common/ops/gravitino/GravitinoLanceNamespaceWrapper.java:
##########
@@ -525,7 +523,12 @@ public ListTablesResponse listTables(
}
@Override
- public DescribeTableResponse describeTable(String tableId, String delimiter)
{
+ public DescribeTableResponse describeTable(String tableId, String delimiter,
Long version) {
+ if (version != null) {
+ throw new UnsupportedOperationException(
+ "Describing specific table version is not supported.");
Review Comment:
Drop operations will be done in `GenericLakehouseCatalogOperations#drop` and
code will not reach `lance#drop`.
Another point is that we do not support drop tables in LRS currently.
##########
lance/lance-common/src/main/java/org/apache/gravitino/lance/common/ops/gravitino/GravitinoLanceNamespaceWrapper.java:
##########
@@ -596,7 +598,7 @@ public CreateTableResponse createTable(
break;
case OVERWRITE:
if (catalog.asTableCatalog().tableExists(tableIdentifier)) {
Review Comment:
OK, I can call it once. The only drawback is that the result of
`tableExists` will be out-of-date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
