FANNG1 commented on code in PR #8996:
URL: https://github.com/apache/gravitino/pull/8996#discussion_r2493425198
##########
catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/utils/TableOpsUtils.java:
##########
@@ -129,7 +129,7 @@ public static SchemaChange buildSchemaChange(TableChange
tableChange)
private static void checkColumnDefaultValue(String fieldName, Expression
defaultValue) {
Preconditions.checkArgument(
Review Comment:
`defaultValue` seems couldn't be null because if user doesn't specify
default value, it would be `DEFAULT_VALUE_NOT_SET`. could you change the code
like below to make the code more robust？
```
Column.DEFAULT_VALUE_NOT_SET.equals(defaultValue)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
