pandeysambhi commented on code in PR #8996:
URL: https://github.com/apache/gravitino/pull/8996#discussion_r2508770303


##########
catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/utils/TableOpsUtils.java:
##########
@@ -129,7 +129,7 @@ public static SchemaChange buildSchemaChange(TableChange 
tableChange)
 
   private static void checkColumnDefaultValue(String fieldName, Expression 
defaultValue) {
     Preconditions.checkArgument(

Review Comment:
   @FANNG1 the check you are asking for is already in place , though not 
written in the conventional Constant first check. The issue mentioned that 
running the test would give the error that needs to be fixed, and as per the 
test, there is a NPE as the default value is null, hence added the check for it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to