yuqi1129 commented on code in PR #9029:
URL: https://github.com/apache/gravitino/pull/9029#discussion_r2497622604
##########
mcp-server/tests/unit/tools/__init__.py:
##########
@@ -14,10 +14,13 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+import logging
from tests.unit.tools.mock_operation import (
MockCatalogOperation,
MockOperation,
MockSchemaOperation,
MockTableOperation,
)
+
+logging.disable(logging.INFO)
Review Comment:
Are you going to disable logging in the MCP testes?
##########
api/src/main/java/org/apache/gravitino/rel/Table.java:
##########
@@ -44,6 +44,28 @@
@Evolving
public interface Table extends Auditable {
+ /**
+ * The reserved property name for the table format. This property indicates
the format of the
+ * table, such as "iceberg", "hudi", "lance", etc. Some catalog
implementations may use this
+ * property to determine the table format and perform specific operations
based on the format.
+ */
+ String PROPERTY_TABLE_FORMAT = "format";
+
+ /**
+ * The reserved property name to indicate whether the table is external.
This property is a
+ * boolean value represented as a string ("true" or "false"). if true (the
table is external), the
+ * drop operation will not delete the underlying data.
+ */
+ String PROPERTY_EXTERNAL = "external";
+
+ /**
+ * The reserved property name for the table location. This property
indicates the physical
+ * location of the table's data, such as a file path or a URI. The location
can be specified when
+ * creating the table. If not, the catalog implementation may use a location
based on the catalog
+ * and schema location properties.
+ */
+ String PROPERTY_LOCATION = "location";
Review Comment:
Do we need to mark `location` as an optional reserved property in `catalog`
and `schema`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
