mchades commented on code in PR #9029:
URL: https://github.com/apache/gravitino/pull/9029#discussion_r2497679816
##########
api/src/main/java/org/apache/gravitino/rel/Table.java:
##########
@@ -44,6 +44,28 @@
@Evolving
public interface Table extends Auditable {
+ /**
+ * The reserved property name for the table format. This property indicates
the format of the
+ * table, such as "iceberg", "hudi", "lance", etc. Some catalog
implementations may use this
+ * property to determine the table format and perform specific operations
based on the format.
+ */
+ String PROPERTY_TABLE_FORMAT = "format";
+
+ /**
+ * The reserved property name to indicate whether the table is external.
This property is a
+ * boolean value represented as a string ("true" or "false"). if true (the
table is external), the
+ * drop operation will not delete the underlying data.
+ */
+ String PROPERTY_EXTERNAL = "external";
Review Comment:
what's the default value of the property? And is it immutable?
##########
api/src/main/java/org/apache/gravitino/rel/Table.java:
##########
@@ -44,6 +44,28 @@
@Evolving
public interface Table extends Auditable {
+ /**
+ * The reserved property name for the table format. This property indicates
the format of the
Review Comment:
It would be more appropriate to use an `optional property` here because
`reserved property` means the property is reserved by Gravitino (or underlaying
catalog) and cannot be set by the user, such as `gravitino.identifier`
https://github.com/apache/gravitino/blob/903f7c81ca15b01c16d4bac39c9dda23da2cc142/core/src/main/java/org/apache/gravitino/connector/PropertyEntry.java#L57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
