mchades commented on code in PR #9097:
URL: https://github.com/apache/gravitino/pull/9097#discussion_r2523400597
##########
flink-connector/flink/src/test/java/org/apache/gravitino/flink/connector/integration/test/iceberg/FlinkIcebergRestCatalogIT.java:
##########
@@ -66,18 +66,16 @@ public void testListSchema() {
TestUtils.assertTableResult(
sql("SHOW DATABASES"),
ResultKind.SUCCESS_WITH_CONTENT,
- Row.of("default"),
Review Comment:
why need to do this change?
##########
api/src/main/java/org/apache/gravitino/rel/indexes/Index.java:
##########
@@ -111,6 +119,12 @@ enum IndexType {
/** IVF_HNSW_FLAT */
IVF_HNSW_SQ,
/** IVF_HNSW_PQ */
- IVF_HNSW_PQ;
+ IVF_HNSW_PQ,
Review Comment:
We should provide a detailed explanation of this index type.
##########
lance/lance-rest-server/src/main/java/org/apache/gravitino/lance/service/rest/LanceTableOperations.java:
##########
@@ -192,14 +198,75 @@ public Response deregisterTable(
}
}
+ @POST
+ @Path("/create_index")
+ @Timed(name = "create-table-index." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "create-table-index", absolute = true)
+ public Response createTableIndex(
+ @PathParam("id") String tableId,
+ @QueryParam("delimiter") @DefaultValue("$") String delimiter,
Review Comment:
plz use `NAMESPACE_DELIMITER_DEFAULT`
##########
lance/lance-rest-server/src/main/java/org/apache/gravitino/lance/service/rest/LanceTableOperations.java:
##########
@@ -192,14 +198,75 @@ public Response deregisterTable(
}
}
+ @POST
+ @Path("/create_index")
+ @Timed(name = "create-table-index." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "create-table-index", absolute = true)
+ public Response createTableIndex(
+ @PathParam("id") String tableId,
+ @QueryParam("delimiter") @DefaultValue("$") String delimiter,
+ @Context HttpHeaders headers,
+ CreateTableIndexRequest createTableIndexRequest) {
+ try {
+ validateCreateTableIndexRequest(createTableIndexRequest);
+ CreateTableIndexResponse response =
+ lanceNamespace.asTableOps().createTableIndex(tableId, delimiter,
createTableIndexRequest);
+ return Response.ok(response).build();
+ } catch (Exception e) {
+ return LanceExceptionMapper.toRESTResponse(tableId, e);
+ }
+ }
+
+ @POST
+ @Path("/index/list")
+ @Timed(name = "list-table-indices." + MetricNames.HTTP_PROCESS_DURATION,
absolute = true)
+ @ResponseMetered(name = "list-table-indices", absolute = true)
+ public Response listTableIndices(
+ @PathParam("id") String tableId,
+ @QueryParam("delimiter") @DefaultValue("$") String delimiter,
Review Comment:
plz use `NAMESPACE_DELIMITER_DEFAULT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
