yuqi1129 commented on code in PR #9097:
URL: https://github.com/apache/gravitino/pull/9097#discussion_r2526023869
##########
flink-connector/flink/src/test/java/org/apache/gravitino/flink/connector/integration/test/iceberg/FlinkIcebergRestCatalogIT.java:
##########
@@ -66,18 +66,16 @@ public void testListSchema() {
TestUtils.assertTableResult(
sql("SHOW DATABASES"),
ResultKind.SUCCESS_WITH_CONTENT,
- Row.of("default"),
Review Comment:
This problem is quite complex. When I upgrade `lance-core` to 0.39, it will
add JUnit 5.10.1 to the classpath and update the JUnit version in the
`flink-connector/flink` module from 5.9.1 to 5.10.1.
Please take care that
```
@Override
public void testListSchema() {
}
```
`testListSchema` in `FlinkIcebergRestCatalogIT` overrides the same method in
`Flinkcommon`, this test will not be executed in Junit 5.9.1 but will be
triggered in 5.10.1. That is to say, the test will never be run in the main
branch but will be invoked in this PR, which is why we need to make such
modifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
