yuqi1129 commented on code in PR #9174:
URL: https://github.com/apache/gravitino/pull/9174#discussion_r2540173880


##########
gradle/libs.versions.toml:
##########
@@ -28,7 +28,8 @@ guava = "32.1.3-jre"
 lombok = "1.18.20"
 slf4j = "2.0.16"
 log4j = "2.24.3"
-lance = "0.34.0"
+lance = "0.39.0"

Review Comment:
   @youngyjd , 
   
   We may need to exclude some jar from lance-core, the following works for me
   
   core/build.gradle.kts
   ```
     implementation(libs.lance) {
       exclude(group = "com.fasterxml.jackson.core", module = "*") // provided 
by gravitino
       exclude(group = "com.fasterxml.jackson.datatype", module = "*") // 
provided by gravitino
       exclude(group = "commons-codec", module = "commons-codec") // provided 
by jcasbin
       
       // Add the following two.
       exclude(group = "com.google.guava", module = "guava") // provided by 
gravitino
       exclude(group = "org.apache.commons", module = "commons-lang3") // 
provided by gravitino
     }
   
   ```



##########
gradle/libs.versions.toml:
##########
@@ -28,7 +28,8 @@ guava = "32.1.3-jre"
 lombok = "1.18.20"
 slf4j = "2.0.16"
 log4j = "2.24.3"
-lance = "0.34.0"
+lance = "0.39.0"

Review Comment:
   @youngyjd , 
   
   We may need to exclude some jars from lance-core. The following works for me
   
   core/build.gradle.kts
   ```
     implementation(libs.lance) {
       exclude(group = "com.fasterxml.jackson.core", module = "*") // provided 
by gravitino
       exclude(group = "com.fasterxml.jackson.datatype", module = "*") // 
provided by gravitino
       exclude(group = "commons-codec", module = "commons-codec") // provided 
by jcasbin
       
       // Add the following two.
       exclude(group = "com.google.guava", module = "guava") // provided by 
gravitino
       exclude(group = "org.apache.commons", module = "commons-lang3") // 
provided by gravitino
     }
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to