mchades commented on code in PR #9174: URL: https://github.com/apache/gravitino/pull/9174#discussion_r2542080595
########## lance/lance-common/src/main/java/org/apache/gravitino/lance/common/config/LanceConfig.java: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.lance.common.config; + +import com.google.common.collect.ImmutableMap; +import java.util.Map; +import org.apache.gravitino.Config; +import org.apache.gravitino.OverwriteDefaultConfig; +import org.apache.gravitino.config.ConfigBuilder; +import org.apache.gravitino.config.ConfigConstants; +import org.apache.gravitino.config.ConfigEntry; + +/** Base Lance REST configuration. */ +public class LanceConfig extends Config implements OverwriteDefaultConfig { + + public static final String LANCE_CONFIG_PREFIX = "gravitino.lance-rest."; + public static final String CONFIG_NAMESPACE_BACKEND = "namespace-backend"; + public static final String CONFIG_METALAKE = "metalake-name"; + public static final String CONFIG_URI = "uri"; + + public static final int DEFAULT_LANCE_REST_SERVICE_HTTP_PORT = 9101; + public static final int DEFAULT_LANCE_REST_SERVICE_HTTPS_PORT = 9533; + public static final String DEFAULT_NAMESPACE_BACKEND = "gravitino"; + public static final String DEFAULT_URI = "http://localhost:8090";; + + public static final ConfigEntry<String> CATALOG_NAME = Review Comment: plz check this file to align with the lance branch https://github.com/apache/gravitino/blob/c847354a257d928150e3bff58f5282b52dd01da6/lance/lance-common/src/main/java/org/apache/gravitino/lance/common/config/LanceConfig.java#L50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
