jerqi commented on code in PR #9091:
URL: https://github.com/apache/gravitino/pull/9091#discussion_r2555107182
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/CatalogMetaService.java:
##########
@@ -92,9 +92,18 @@ public CatalogPO getCatalogPOByName(String metalakeName,
String catalogName) {
metricsSource = GRAVITINO_RELATIONAL_STORE_METRIC_NAME,
baseMetricName = "getCatalogIdByMetalakeAndCatalogName")
public CatalogIds getCatalogIdByMetalakeAndCatalogName(String metalakeName,
String catalogName) {
- return SessionUtils.getWithoutCommit(
- CatalogMetaMapper.class,
- mapper ->
mapper.selectCatalogIdByMetalakeNameAndCatalogName(metalakeName, catalogName));
+ CatalogIds catalogIds =
+ SessionUtils.getWithoutCommit(
+ CatalogMetaMapper.class,
+ mapper ->
+
mapper.selectCatalogIdByMetalakeNameAndCatalogName(metalakeName, catalogName));
+ if (catalogIds == null) {
Review Comment:
We add check in the upper layer. It's not unified and convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
