yuqi1129 commented on code in PR #9091: URL: https://github.com/apache/gravitino/pull/9091#discussion_r2558890573
########## core/src/main/java/org/apache/gravitino/cache/CachedEntityIdResolver.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.cache; + +import org.apache.gravitino.Entity; +import org.apache.gravitino.HasIdentifier; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.meta.EntityIdResolver; +import org.apache.gravitino.meta.NamespacedEntityId; +import org.apache.gravitino.utils.NameIdentifierUtil; + +public class CachedEntityIdResolver implements EntityIdResolver { + + private final EntityCache entityCache; + private final EntityIdResolver underlyingResolver; + + public CachedEntityIdResolver(EntityCache entityCache, EntityIdResolver underlyingResolver) { + this.entityCache = entityCache; + this.underlyingResolver = underlyingResolver; + } + + @Override + public NamespacedEntityId getEntityIds(NameIdentifier nameIdentifier, Entity.EntityType type) { + return entityCache Review Comment: What concerns me is that the cache key of the entity store cache is `NameIdentier` and `EntityType.`, and that is the same as what you did for entity id, that is The following two entries will never be in the cache at the same time. ``` <ident1, table> ---> table1 entity <ident, table> ---> table1 id ``` This PR will degrade the effectiveness of the entity store cache for the entity, though we will get some improvement on ID retrieval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
