jerryshao commented on code in PR #9279:
URL: https://github.com/apache/gravitino/pull/9279#discussion_r2568192726
##########
catalogs/catalog-lakehouse-generic/src/main/java/org/apache/gravitino/catalog/lakehouse/lance/LanceTableOperations.java:
##########
@@ -100,45 +109,48 @@ public Table createTable(
String location = properties.get(Table.PROPERTY_LOCATION);
Preconditions.checkArgument(
StringUtils.isNotBlank(location), "Table location must be specified");
- Map<String, String> storageProps =
LancePropertiesUtils.getLanceStorageOptions(properties);
+
+ // Extract creation mode from properties
+ CreationMode mode =
+ Optional.ofNullable(properties.get(LANCE_CREATION_MODE))
+ .map(CreationMode::valueOf)
+ .orElse(CreationMode.CREATE);
boolean register =
-
Optional.ofNullable(properties.get(LanceTableDelegator.PROPERTY_LANCE_TABLE_REGISTER))
+ Optional.ofNullable(properties.get(LANCE_TABLE_REGISTER))
.map(Boolean::parseBoolean)
.orElse(false);
- if (register) {
- // If this is a registration operation, just create the table metadata
without creating a new
- // dataset
- return super.createTable(
- ident, columns, comment, properties, partitions, distribution,
sortOrders, indexes);
+
+ // Handle EXIST_OK mode - check if table exists first
+ if (mode == CreationMode.EXIST_OK) {
+ try {
+ return super.loadTable(ident);
+ } catch (NoSuchTableException e) {
+ // Table doesn't exist, proceed with creation
+ }
}
- try (Dataset ignored =
- Dataset.create(
- new RootAllocator(),
- location,
- convertColumnsToArrowSchema(columns),
- new
WriteParams.Builder().withStorageOptions(storageProps).build())) {
- // Only create the table metadata in Gravitino after the Lance dataset
is successfully
- // created.
- return super.createTable(
- ident, columns, comment, properties, partitions, distribution,
sortOrders, indexes);
- } catch (NoSuchSchemaException e) {
- throw e;
- } catch (TableAlreadyExistsException e) {
- // If the table metadata already exists, but the underlying lance table
was just created
- // successfully, we need to clean up the created lance table to avoid
orphaned datasets.
- Dataset.drop(location,
LancePropertiesUtils.getLanceStorageOptions(properties));
- throw e;
- } catch (IllegalArgumentException e) {
- if (e.getMessage().contains("Dataset already exists")) {
- throw new TableAlreadyExistsException(
- e, "Lance dataset already exists at location %s", location);
+ // Handle OVERWRITE mode - drop existing table if present
+ if (mode == CreationMode.OVERWRITE) {
+ if (register) {
+ dropTable(ident);
+ } else {
+ purgeTable(ident);
Review Comment:
There's a lock for each operation, so it is fine without issue for
single-node operation. But this should be an issue for multi-nodes depolyment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
