jerryshao commented on code in PR #9279:
URL: https://github.com/apache/gravitino/pull/9279#discussion_r2570516293
##########
catalogs/catalog-lakehouse-generic/src/main/java/org/apache/gravitino/catalog/lakehouse/lance/LanceTableDelegator.java:
##########
@@ -44,20 +43,28 @@ public String tableFormat() {
public List<PropertyEntry<?>> tablePropertyEntries() {
return ImmutableList.of(
PropertyEntry.stringOptionalPropertyPrefixEntry(
- PROPERTY_LANCE_STORAGE_OPTIONS_PREFIX,
+ LANCE_STORAGE_OPTIONS_PREFIX,
"The storage options passed to Lance table.",
false /* immutable */,
null /* default value*/,
false /* hidden */,
false /* reserved */),
PropertyEntry.booleanPropertyEntry(
- PROPERTY_LANCE_TABLE_REGISTER,
+ LANCE_TABLE_REGISTER,
"Whether this is a table registration operation.",
false,
true /* immutable */,
false /* defaultValue */,
false /* hidden */,
- false));
+ false),
+ PropertyEntry.stringPropertyEntry(
Review Comment:
I can change it. But it is not so necessary. Because we cannot get
`HasPropertyMetadata` object in `LanceTableOperations`, so we cannot leverage
PropertyMetadata API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
