jerryshao commented on code in PR #9396:
URL: https://github.com/apache/gravitino/pull/9396#discussion_r2597187066
##########
clients/client-python/gravitino/rest/rest_utils.py:
##########
@@ -16,11 +16,12 @@
# under the License.
import urllib.parse
+
from gravitino.exceptions.base import IllegalArgumentException
def encode_string(to_encode: str):
if to_encode is None:
raise IllegalArgumentException("Invalid string to encode: None")
- return urllib.parse.quote(to_encode, encoding="utf-8")
+ return urllib.parse.quote(to_encode, safe="", encoding="utf-8")
Review Comment:
What is the meaning of `safe=""`?
##########
clients/client-python/gravitino/rest/rest_utils.py:
##########
@@ -16,11 +16,12 @@
# under the License.
import urllib.parse
+
from gravitino.exceptions.base import IllegalArgumentException
def encode_string(to_encode: str):
if to_encode is None:
raise IllegalArgumentException("Invalid string to encode: None")
- return urllib.parse.quote(to_encode, encoding="utf-8")
+ return urllib.parse.quote(to_encode, safe="", encoding="utf-8")
Review Comment:
What is the meaning of adding `safe=""`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
