Copilot commented on code in PR #9396: URL: https://github.com/apache/gravitino/pull/9396#discussion_r2645435960
########## clients/client-python/tests/integration/test_relational_table.py: ########## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +from datetime import date +from random import randint + +from gravitino import ( + Catalog, + GravitinoAdminClient, + GravitinoClient, + NameIdentifier, +) +from gravitino.api.rel.expressions.literals.literals import Literals +from gravitino.api.rel.partitions.partitions import Partitions +from gravitino.api.rel.types.types import Types +from gravitino.dto.rel.column_dto import ColumnDTO +from gravitino.dto.rel.partitioning.identity_partitioning_dto import ( + IdentityPartitioningDTO, +) +from gravitino.utils import HTTPClient +from tests.integration.containers.hdfs_container import HDFSContainer +from tests.integration.integration_test_env import IntegrationTestEnv + +logger = logging.getLogger(__name__) + + +class TestRelationalTable(IntegrationTestEnv): + METALAKE_NAME: str = "TestRelationalTable_metalake" + str(randint(1, 10000)) + CATALOG_NAME: str = "relational_catalog" + CATALOG_PROVIDER: str = "hive" + SCHEMA_NAME: str = "test_schema" + TABLE_NAME: str = "test_table" + TABLE_IDENT: NameIdentifier = NameIdentifier.of(SCHEMA_NAME, TABLE_NAME) + + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.hdfs_container: HDFSContainer = HDFSContainer() + hive_metastore_uri = f"thrift://{cls.hdfs_container.get_ip()}:9083" + logger.info("Started Hive container with metastore URI: %s", hive_metastore_uri) + cls.rest_client = HTTPClient("http://localhost:8090";) Review Comment: The HTTPClient import and rest_client variable assignment appear to be unused in this test class. Consider removing the import on line 35 and the variable assignment on line 56 if they are not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
