FANNG1 commented on code in PR #8980:
URL: https://github.com/apache/gravitino/pull/8980#discussion_r2601590458


##########
docs/iceberg-rest-service.md:
##########
@@ -447,6 +448,20 @@ Gravitino features a pluggable cache system for updating 
or retrieving table met
 
 Gravitino provides the build-in 
`org.apache.gravitino.iceberg.common.cache.LocalTableMetadataCache` to store 
the cached data in the memory. You could also implement your custom table 
metadata cache by implementing the 
`org.apache.gravitino.iceberg.common.cache.TableMetadataCache` interface.
 
+### Iceberg scan plan cache configuration
+
+Gravitino caches scan plan results to speed up repeated queries with identical 
parameters. The cache uses snapshot ID as part of the cache key, so queries 
against different snapshots will not use stale cached data.
+
+| Configuration item                                         | Description     
                                         | Default value | Required | Since 
Version |
+|------------------------------------------------------------|----------------------------------------------------------|---------------|----------|---------------|
+| `gravitino.iceberg-rest.scan-plan-cache-impl`              | The 
implementation of the scan plan cache.               | (none)        | No       
| 1.1.0         |

Review Comment:
   Could we disable cache by default? mainly for memory and data correctness 
concerns



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to