FANNG1 commented on code in PR #8980:
URL: https://github.com/apache/gravitino/pull/8980#discussion_r2601594272
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java:
##########
@@ -422,6 +447,28 @@ private <T extends Scan> T applyScanStatsFields(T scan,
PlanTableScanRequest sca
return scan;
}
+ private ScanPlanCache loadScanPlanCache(IcebergConfig config) {
+ String impl = config.get(IcebergConfig.SCAN_PLAN_CACHE_IMPL);
+ if (StringUtils.isBlank(impl)) {
+ LOG.info("Scan plan cache is not configured, using default
LocalScanPlanCache");
+ return new LocalScanPlanCache(
Review Comment:
seems we should pass cache capacity and expire time to other impls too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
