jerqi commented on code in PR #9565:
URL: https://github.com/apache/gravitino/pull/9565#discussion_r2652111368
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/GravitinoCatalogManager.java:
##########
@@ -54,8 +61,35 @@ private GravitinoCatalogManager(
this.gravitinoUri = gravitinoUri;
this.metalakeName = metalakeName;
this.gravitinoClientConfig = gravitinoClientConfig;
- this.gravitinoClient =
-
GravitinoAdminClient.builder(gravitinoUri).withClientConfig(gravitinoClientConfig).build();
+
+ String authType =
gravitinoClientConfig.get(GravitinoCatalogStoreFactoryOptions.AUTH_TYPE);
+
+ // Only OAuth is explicitly configured; otherwise follow Flink security
(Kerberos if enabled,
Review Comment:
Gravitino client authentication type should follow the Flink first. If Flink
used simple mode, Gravitino used simple mode. If Flink used Kerberos mode,
Gravitino used Kerberos mode.
Flink didn't support OAuth mode, so we should allow to set the oauth
explicitly.
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/GravitinoCatalogManager.java:
##########
@@ -54,8 +61,35 @@ private GravitinoCatalogManager(
this.gravitinoUri = gravitinoUri;
this.metalakeName = metalakeName;
this.gravitinoClientConfig = gravitinoClientConfig;
- this.gravitinoClient =
-
GravitinoAdminClient.builder(gravitinoUri).withClientConfig(gravitinoClientConfig).build();
+
+ String authType =
gravitinoClientConfig.get(GravitinoCatalogStoreFactoryOptions.AUTH_TYPE);
+
+ // Only OAuth is explicitly configured; otherwise follow Flink security
(Kerberos if enabled,
Review Comment:
Gravitino client authentication type should follow the Flink first.
If Flink used simple mode, Gravitino used simple mode. If Flink used
Kerberos mode, Gravitino used Kerberos mode.
Flink didn't support OAuth mode, so we should allow to set the oauth
explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
