mchades commented on code in PR #9551: URL: https://github.com/apache/gravitino/pull/9551#discussion_r2659657215
########## api/src/main/java/org/apache/gravitino/function/FunctionChange.java: ########## @@ -0,0 +1,393 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.function; + +import com.google.common.base.Preconditions; +import java.util.Arrays; +import java.util.Objects; +import org.apache.gravitino.annotation.Evolving; + +/** Represents a change that can be applied to a function. */ +@Evolving +public interface FunctionChange { + + /** + * Create a {@link FunctionChange} to update the comment of a function. + * + * @param newComment The new comment value. + * @return The change instance. + */ + static FunctionChange updateComment(String newComment) { + return new UpdateComment(newComment); + } + + /** + * Create a {@link FunctionChange} to add a new definition (overload) to a function. + * + * @param definition The new definition to add. + * @return The change instance. + */ + static FunctionChange addDefinition(FunctionDefinition definition) { Review Comment: > So, do you mean that one definition with "fixed parameters" can have multiple implementations? For example, the input is `a: String`, then it can have Java, Python different implementations? yes. > Does Iceberg also follow such implementations? My feeling is that multi-level definitions makes this too complicated to understand. yes. Iceberg UDF design includes corresponding fields named [definitions](https://github.com/apache/iceberg/pull/14117/changes#diff-109630c35eec3c379bb0cba90c8a2f4329472d71098bce770b3fd2efcb90e5e8R60) and [representations](https://github.com/apache/iceberg/pull/14117/changes#diff-109630c35eec3c379bb0cba90c8a2f4329472d71098bce770b3fd2efcb90e5e8R168) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
