yuqi1129 commented on code in PR #9776:
URL: https://github.com/apache/gravitino/pull/9776#discussion_r2754183528
##########
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/operation/JdbcTableOperations.java:
##########
@@ -106,12 +107,43 @@ public void create(
Distribution distribution,
Index[] indexes)
throws TableAlreadyExistsException {
+ create(
+ databaseName,
+ tableName,
+ columns,
+ comment,
+ properties,
+ partitioning,
+ distribution,
+ indexes,
+ null);
+ }
+
+ @Override
+ public void create(
+ String databaseName,
+ String tableName,
+ JdbcColumn[] columns,
+ String comment,
+ Map<String, String> properties,
+ Transform[] partitioning,
+ Distribution distribution,
+ Index[] indexes,
+ SortOrder[] sortOrders)
Review Comment:
> Is it reasonable to expose it as an interface field just for ClickHouse?
Possible other JDBC catalogs will use it in the future.
> How did we handle this for Doris and StarRocks?
The two do not support sort order currently.
Since the create table API supports `SortOrder`, I would rather use it as
the way in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
