diqiu50 commented on code in PR #9776:
URL: https://github.com/apache/gravitino/pull/9776#discussion_r2757712504
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/converter/ClickHouseColumnDefaultValueConverter.java:
##########
@@ -78,17 +77,18 @@ public Expression toGravitino(
return nullable ? Literals.NULL : DEFAULT_VALUE_NOT_SET;
}
- String reallyType = type.getTypeName();
- if (reallyType.startsWith("Nullable(")) {
- reallyType = type.getTypeName().substring(9, type.getTypeName().length()
- 1);
+ String realType = type.getTypeName();
+ if (realType.startsWith("Nullable(")) {
+ realType =
+ type.getTypeName().substring("Nullable(".length(),
type.getTypeName().length() - 1);
Review Comment:
Please define a constant value of `Nullable(` or a regular expression patten
to handle this match
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/converter/ClickHouseTypeConverter.java:
##########
@@ -117,9 +133,11 @@ public Type toGravitino(JdbcTypeBean typeBean) {
case DATE32:
return Types.DateType.get();
case DATETIME:
+ // Gravitino timestamp type does not support time zones with detail
zone name like 'UTC'
+ // or 'America/Los_Angeles'. So we ignore it here and use ExternalType
for such cases.
return Types.TimestampType.withoutTimeZone();
Review Comment:
What's the time precision here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
