yuqi1129 commented on code in PR #9861: URL: https://github.com/apache/gravitino/pull/9861#discussion_r2761768934
########## trino-connector/trino-connector-435-439/build.gradle.kts: ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import com.diffplug.gradle.spotless.SpotlessExtension +import net.ltgt.gradle.errorprone.errorprone + +plugins { + `java-library` + `maven-publish` +} + +val supportedTrinoVersion = 435 +val minSupportedTrinoVersionProperty = providers.gradleProperty("minSupportedTrinoVersion").map { it.trim().toInt() } +val trinoVersionProvider = + providers.gradleProperty("trinoVersion").map { it.trim().toInt() }.orElse(minSupportedTrinoVersionProperty) + +val resolvedTrinoVersion = trinoVersionProvider.get() +check(resolvedTrinoVersion >= supportedTrinoVersion) { + "Invalid trinoVersion=$resolvedTrinoVersion for project ${project.path}. " + + "This module requires trinoVersion >= $supportedTrinoVersion. " + + "Either omit -PtrinoVersion to use minSupportedTrinoVersion=${minSupportedTrinoVersionProperty.get()}, " + + "or set -PtrinoVersion to a supported value." Review Comment: I can't get the meaning of the error message: Does it mean that we can skip the error during compilation by setting `minSupportedTrinoVersion`? ########## integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/TrinoITContainers.java: ########## @@ -70,6 +73,11 @@ public void launch( env.put("TRINO_VERSION", String.valueOf(trinoVersion)); } if (trinoConnectorDir != null) { + // If the provided path is relative, resolve it against the current working directory. Review Comment: I couldn't see your code follow your comments here. ########## .github/workflows/trino-integration-test.yml: ########## @@ -73,7 +76,7 @@ jobs: - name: Package Gravitino run: | - ./gradlew compileDistribution compileTrinoConnector -x test + ./gradlew build -x test Review Comment: Why did you change it to build Gravitino? If it did need such changes, you'd better change the name `Package Gravitino`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
