diqiu50 commented on code in PR #9861: URL: https://github.com/apache/gravitino/pull/9861#discussion_r2763721710
########## trino-connector/trino-connector-435-439/build.gradle.kts: ########## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import com.diffplug.gradle.spotless.SpotlessExtension +import net.ltgt.gradle.errorprone.errorprone + +plugins { + `java-library` + `maven-publish` +} + +val supportedTrinoVersion = 435 +val minSupportedTrinoVersionProperty = providers.gradleProperty("minSupportedTrinoVersion").map { it.trim().toInt() } +val trinoVersionProvider = + providers.gradleProperty("trinoVersion").map { it.trim().toInt() }.orElse(minSupportedTrinoVersionProperty) + +val resolvedTrinoVersion = trinoVersionProvider.get() +check(resolvedTrinoVersion >= supportedTrinoVersion) { + "Failed to build the module ${project.path} of trinoVersion=$resolvedTrinoVersion. " + + "This module requires trinoVersion >= $supportedTrinoVersion. " + + "Please set '-PtrinoVersion' in the command or set config the 'minSupportedTrinoVersion' of gradle.properties." +} +val trinoVersion = resolvedTrinoVersion + +java { + toolchain.languageVersion.set(JavaLanguageVersion.of(24)) Review Comment: Handling it in a unified way is simpler. Some later versions upgrade the JDK, but the SPI remains unchanged. ########## trino-connector/trino-connector-435-439/build.gradle.kts: ########## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import com.diffplug.gradle.spotless.SpotlessExtension +import net.ltgt.gradle.errorprone.errorprone + +plugins { + `java-library` + `maven-publish` +} + +val supportedTrinoVersion = 435 +val minSupportedTrinoVersionProperty = providers.gradleProperty("minSupportedTrinoVersion").map { it.trim().toInt() } +val trinoVersionProvider = + providers.gradleProperty("trinoVersion").map { it.trim().toInt() }.orElse(minSupportedTrinoVersionProperty) + +val resolvedTrinoVersion = trinoVersionProvider.get() +check(resolvedTrinoVersion >= supportedTrinoVersion) { + "Failed to build the module ${project.path} of trinoVersion=$resolvedTrinoVersion. " + + "This module requires trinoVersion >= $supportedTrinoVersion. " + + "Please set '-PtrinoVersion' in the command or set config the 'minSupportedTrinoVersion' of gradle.properties." +} +val trinoVersion = resolvedTrinoVersion + +java { + toolchain.languageVersion.set(JavaLanguageVersion.of(24)) Review Comment: Yes, handling it in a unified way is simpler. Some later versions upgrade the JDK, but the SPI remains unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
