diqiu50 commented on code in PR #9776:
URL: https://github.com/apache/gravitino/pull/9776#discussion_r2763042892
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/ClickHouseConstants.java:
##########
@@ -30,6 +31,7 @@ public class ClickHouseConstants {
public static final String CLUSTER_REMOTE_DATABASE =
"cluster-remote-database";
public static final String CLUSTER_REMOTE_TABLE = "cluster-remote-table";
+ /*---------------------The following are ClickHouse table related
properties---------------------*/
Review Comment:
Table common properties
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/ClickHouseConstants.java:
##########
Review Comment:
Distribution table properties
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/ClickHouseConstants.java:
##########
@@ -30,6 +31,7 @@ public class ClickHouseConstants {
public static final String CLUSTER_REMOTE_DATABASE =
"cluster-remote-database";
public static final String CLUSTER_REMOTE_TABLE = "cluster-remote-table";
+ /*---------------------The following are ClickHouse table related
properties---------------------*/
Review Comment:
You’d better separate properties using naming conventions or scopes. It will
get very messy here if we add more later.
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/ClickHouseConstants.java:
##########
@@ -21,6 +21,7 @@
public class ClickHouseConstants {
+ /*---------------------The following are ClickHouse cluster related
properties---------------------*/
Review Comment:
DDL operation properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
