diqiu50 commented on code in PR #9776:
URL: https://github.com/apache/gravitino/pull/9776#discussion_r2764158212
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/ClickHouseTablePropertiesMetadata.java:
##########
@@ -51,28 +51,40 @@ public class ClickHouseTablePropertiesMetadata extends
JdbcTablePropertiesMetada
false,
false);
- // The following properties are specific to ClickHouse Distributed engine,
so it's recommended to
- // only use them when ENGINE is set to DISTRIBUTED.
+ // The following two are for cluster tables
+ public static final PropertyEntry<String> CLUSTER_NAME_PROPERTY_ENTRY =
+ stringOptionalPropertyEntry(
+ ClusterConstants.NAME,
+ "The cluster name for ClickHouse distributed tables",
+ false,
+ "",
+ false);
public static final PropertyEntry<String> ON_CLUSTER_PROPERTY_ENTRY =
stringOptionalPropertyEntry(
- ON_CLUSTER, "The cluster name for ClickHouse distributed tables",
false, "", false);
+ ClusterConstants.ON_CLUSTER,
+ "The cluster name for ClickHouse distributed tables",
Review Comment:
The description is incorrect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
