Copilot commented on code in PR #9922:
URL: https://github.com/apache/gravitino/pull/9922#discussion_r2785523607
##########
.github/workflows/build.yml:
##########
@@ -46,9 +46,12 @@ jobs:
- '!**/*.svg'
spark_connector_changes:
- spark-connector/**
+ mcp_server_changes:
+ - mcp-server/**
outputs:
source_changes: ${{ steps.filter.outputs.source_changes }}
spark_connector_changes: ${{
steps.filter.outputs.spark_connector_changes }}
+ mcp_server_changes: ${{ steps.filter.outputs.mcp_server_changes }}
Review Comment:
`mcp_server_changes` is computed, but `source_changes` does not include
`mcp-server/**` and the `build` job is gated by
`needs.changes.outputs.source_changes == 'true'`. As a result, changes like
`mcp-server/uv.lock`, `pyproject.toml`, `pylintrc`, etc. won’t trigger the
`build` job at all, so MCP build/tests won’t run even though MCP content
changed. Consider either adding `mcp-server/**` into the `source_changes`
filter or updating the `build` job `if:` to also run when `mcp_server_changes
== 'true'`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
