FANNG1 commented on code in PR #9904:
URL: https://github.com/apache/gravitino/pull/9904#discussion_r2801549471
##########
maintenance/optimizer/src/main/java/org/apache/gravitino/maintenance/optimizer/recommender/Recommender.java:
##########
@@ -302,4 +327,23 @@ private SupportTableStatistics
requireTableStatisticsProvider() {
+ "configure a statistics provider that implements
SupportTableStatistics.",
statisticsProvider.name()));
}
+
+ private void logRecommendation(String strategyName, StrategyEvaluation
evaluation) {
+ JobExecutionContext jobExecutionContext =
+ evaluation
+ .jobExecutionContext()
+ .orElseThrow(
+ () ->
+ new IllegalStateException(
+ "Job execution context is missing for evaluation of
strategy "
+ + strategyName));
+ System.out.println(
Review Comment:
Currently, `Recommender` is used in CLI, so a console summary output is
clearer, but this is not a good design, it's more resonable to use
`System.out` in CLI part, I will polish it in later CLI PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
