justinmclean commented on PR #10183: URL: https://github.com/apache/gravitino/pull/10183#issuecomment-3995590665
Thanks for the PR, but a little more is needed here: 1. Still vulnerable to secondary NPE in catch blocks - The inline null-guards only protect the request, not nested fields. 2. The Inline ternary style is getting hard to read/maintain. 3. It is missing unit tests to cover the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
