justinmclean commented on PR #10183: URL: https://github.com/apache/gravitino/pull/10183#issuecomment-4000467400
@jerryshao Thanks for the feedback. I agree we should avoid defensive checks everywhere, but I verified this specific path is reproducible in normal server execution. How to trigger: Start GravitinoServer Send POST /api/metalakes/m/catalogs/c/schemas Headers: Content-Type: application/json, Accept: application/vnd.gravitino.v1+json Body: empty Observed result: createMetalake path (with null guard): returns 400 createSchema path (no null guard): returns 500 So the request body can still be null at handler boundary in our stack, and endpoints without an early guard can fail with server error. This is not about C/C++-style pointer safety; it is about HTTP contract correctness in Java: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
