Copilot commented on code in PR #10199:
URL: https://github.com/apache/gravitino/pull/10199#discussion_r2887246611
##########
catalogs-contrib/catalog-jdbc-oceanbase/src/test/java/org/apache/gravitino/catalog/oceanbase/integration/test/CatalogOceanBaseIT.java:
##########
@@ -304,7 +304,7 @@ void testOperationOceanBaseSchema() {
// create failed check.
NameIdentifier table = NameIdentifier.of(testSchemaName, "test_table");
Assertions.assertThrows(
- NoSuchSchemaException.class,
+ NotFoundException.class,
() ->
Review Comment:
The asserted exception was widened from `NoSuchSchemaException` to its base
`NotFoundException`, but this PR is otherwise only changing dependency scopes.
Since `NoSuchSchemaException` already extends `NotFoundException`, this change
makes the test less specific and may mask regressions; unless the underlying
behavior truly changed, keep asserting `NoSuchSchemaException` (or add a brief
rationale in the PR/commit if the broader type is required).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
