Copilot commented on code in PR #10199:
URL: https://github.com/apache/gravitino/pull/10199#discussion_r2888755449
##########
catalogs/catalog-jdbc-common/build.gradle.kts:
##########
@@ -38,10 +38,10 @@ artifacts {
}
dependencies {
- implementation(project(":api"))
+ compileOnly(project(":api"))
implementation(project(":catalogs:catalog-common"))
- implementation(project(":common"))
- implementation(project(":core"))
+ compileOnly(project(":common"))
+ compileOnly(project(":core"))
Review Comment:
Switching `:api`/`:common`/`:core` from `implementation` to `compileOnly`
changes the published Gradle/Maven metadata for this module (these dependencies
will no longer be pulled transitively by downstream consumers). This is
potentially user-facing for anyone depending on `catalog-jdbc-common` as a
library, so the PR description’s “user-facing change: N/A” looks inaccurate;
please update the PR description/release notes (or confirm these artifacts are
not intended for external consumption).
##########
catalogs-contrib/catalog-jdbc-oceanbase/src/test/java/org/apache/gravitino/catalog/oceanbase/integration/test/CatalogOceanBaseIT.java:
##########
@@ -304,7 +304,7 @@ void testOperationOceanBaseSchema() {
// create failed check.
NameIdentifier table = NameIdentifier.of(testSchemaName, "test_table");
Assertions.assertThrows(
- NoSuchSchemaException.class,
+ NotFoundException.class,
() ->
Review Comment:
This PR is described as a dependency-scope refactor, but this hunk also
changes the expected exception type for `createTable` after dropping a schema.
If this is part of a separate behavior/bug fix, please call it out explicitly
in the PR description (or split it into a dedicated PR) so reviewers can track
why this behavior changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
