Copilot commented on code in PR #10385:
URL: https://github.com/apache/gravitino/pull/10385#discussion_r2929899763
##########
.github/workflows/build.yml:
##########
@@ -84,7 +84,7 @@ jobs:
- name: Build with Gradle
run: |
- ./gradlew release -x test
+ ./gradlew build -x test
Review Comment:
`./gradlew build -x test` in this lightweight `compile-check` job will
execute `build` for all subprojects, including ones with heavy/non-Java build
steps (e.g., `:mcp-server:build` installs uv/creates a venv and runs pylint;
`:web:web:build` runs pnpm lint/dist; `:docs:build` runs an npx lint). The main
`build` job explicitly excludes some of these tasks, but this job does not,
which can cause unexpected CI failures and longer runtimes. Consider switching
this job to `assemble` (or `build` with the same `-x` exclusions used
elsewhere) so it stays a compile-only sanity check.
##########
dev/release/release-build.sh:
##########
@@ -348,8 +348,8 @@ if [[ "$1" == "publish-release" ]]; then
cd ..
$GRADLE clean
- $GRADLE release -x test -PdefaultScalaVersion=2.12
- $GRADLE release -x test -PdefaultScalaVersion=2.13
+ $GRADLE build -x test -PdefaultScalaVersion=2.12
+ $GRADLE build -x test -PdefaultScalaVersion=2.13
Review Comment:
Switching from the custom `release` task (which depended on `assemble`) to
`build -x test` will now run the full `build` lifecycle for *all* subprojects,
including ones with non-Java build steps (e.g., `:mcp-server:build` creates a
Python venv / installs deps, and `:web:web:build` runs pnpm lint/dist). If the
publish script only needs Maven artifacts (it already runs
`publishToMavenLocal` right after), consider using `assemble` here or
explicitly excluding non-release modules/tasks (at least `:mcp-server:build`,
and likely docs/web) to avoid adding network/tooling requirements and reduce
release-time failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
