FANNG1 commented on code in PR #10385:
URL: https://github.com/apache/gravitino/pull/10385#discussion_r2937852829
##########
build.gradle.kts:
##########
@@ -331,39 +332,24 @@ subprojects {
mavenLocal()
}
+ val jdk8CompatibleProjectNames = setOf("api", "common", "catalog-common",
"hadoop-common")
Review Comment:
Done. I merged the exact-name and prefix matching into a single
`jdk8CompatibleProjectPathPrefixes` set and simplified `compatibleWithJDK8` to
match by project path prefix only.
##########
build.gradle.kts:
##########
@@ -450,6 +446,7 @@ subprojects {
}
tasks.withType<JavaCompile>().configureEach {
+ options.encoding = "UTF-8"
Review Comment:
This line keeps Java compilation independent of the host default charset.
Without it, modules that already contain non-ASCII source text can fail to
compile on machines whose default encoding is not UTF-8. I kept it and added a
short comment to make the reason explicit.
##########
.github/workflows/build.yml:
##########
@@ -84,7 +84,7 @@ jobs:
- name: Build with Gradle
run: |
- ./gradlew release -x test
+ ./gradlew assemble
Review Comment:
`assemble` only builds/assembles artifacts, while `build` includes both
`assemble` and `check`. In this repo, several non-Java tasks are wired to
`build` but not to `assemble` (for example `mcp-server`, `client-python`, and
docs), so `assemble` keeps `compile-check` lightweight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
