jerryshao commented on code in PR #10424:
URL: https://github.com/apache/gravitino/pull/10424#discussion_r2938873402
##########
.github/workflows/build.yml:
##########
@@ -64,10 +65,52 @@ jobs:
- spark-connector/**
mcp_server_changes:
- mcp-server/**
+ maintenance_source_changes:
+ - 'maintenance/**'
+ maintenance_changes:
+ - '.github/**'
+ - 'maintenance/**'
+ - 'api/**'
+ - 'common/**'
+ - 'core/**'
+ - 'catalogs/catalog-common/**'
+ - 'clients/client-java/**'
+ - 'integration-test-common/**'
+ - 'server/**'
+ - 'server-common/**'
+ - 'build.gradle.kts'
+ - 'gradle.properties'
+ - 'gradlew'
+ - 'settings.gradle.kts'
+ - 'gradle/**'
+ - name: Determine maintenance-only source changes
+ id: maintenance_only
+ env:
+ SOURCE_CHANGE_FILES: ${{ steps.filter.outputs.source_changes_files }}
+ run: |
+ python3 - <<'PY'
+ import json
+ import os
+
+ source_files = json.loads(os.environ.get("SOURCE_CHANGE_FILES") or
"[]")
+ maintenance_only = bool(source_files) and all(
+ path.startswith("maintenance/") for path in source_files
+ )
+
+ with open(os.environ["GITHUB_OUTPUT"], "a", encoding="utf-8") as
output:
+ output.write(
+ "maintenance_only_source_changes="
+ + ("true" if maintenance_only else "false")
+ + "\n"
+ )
+ PY
outputs:
source_changes: ${{ steps.filter.outputs.source_changes }}
spark_connector_changes: ${{
steps.filter.outputs.spark_connector_changes }}
mcp_server_changes: ${{ steps.filter.outputs.mcp_server_changes }}
+ maintenance_source_changes: ${{
steps.filter.outputs.maintenance_source_changes }}
+ maintenance_changes: ${{ steps.filter.outputs.maintenance_changes }}
+ maintenance_only_source_changes: ${{
steps.maintenance_only.outputs.maintenance_only_source_changes }}
Review Comment:
What's the difference between these 3 different changes, I'm so confused
about this? Can you use a better name to clarify different usages? Also, please
add the comments to explain different usage scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
