FANNG1 commented on PR #10424: URL: https://github.com/apache/gravitino/pull/10424#issuecomment-4071992440
Follow-up update: I simplified the routing logic in the latest change. What changed: - remove the extra maintenance-related routing flags - keep a single routing flag: `maintenance_only_changes` - route only pure `maintenance/**` source changes to the maintenance-only build path - route everything else to the normal full build flow Why I changed it: - the previous version optimized more cases, but the routing logic was harder to understand and maintain - this version keeps the main goal of the PR, which is avoiding the full build when the PR only changes maintenance sources - the workflow is now easier to reason about because the rule becomes a simple binary decision: maintenance-only vs full build Trade-off: - we give up some fine-grained optimization - for example, if an upstream dependency of maintenance changes, we now run the full build instead of trying to selectively route maintenance validation - in return, the workflow becomes much simpler, and the maintenance cost of the CI rule is lower So this change intentionally favors readability and maintainability over squeezing out every possible CI optimization case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
