jerryshao commented on code in PR #10661: URL: https://github.com/apache/gravitino/pull/10661#discussion_r3045012602
########## core/src/main/java/org/apache/gravitino/tag/TagManager.java: ########## Review Comment: The reason why we don't throw `EntityAlreadyExistsException` and throw `RuntimeException` instead is that we don't define `EntityAlreadyExistsException` in the API signature. If we change to throw this exception, the API signature will be broken. So if we want to throw this exception, we should basically update the API signature, not just simply throwing an exception here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
