justinmclean commented on code in PR #10661: URL: https://github.com/apache/gravitino/pull/10661#discussion_r3049571253
########## core/src/main/java/org/apache/gravitino/tag/TagManager.java: ########## Review Comment: TagAlreadyExistsException is already unchecked, so you don’t need to change the public throws signatures here. The correct fix is to keep the API unchanged and only convert the EntityAlreadyExistsException in TagManager.alterTag(...) into TagAlreadyExistsException, so the existing REST handler returns 409 instead of 500. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
