FANNG1 commented on code in PR #10637: URL: https://github.com/apache/gravitino/pull/10637#discussion_r3206679916
########## docs/lance-rest-integration.md: ########## @@ -158,6 +158,7 @@ pip install lance-ray :::info - Ray will be automatically installed if not already present - lance-ray is currently tested with Ray versions 2.41.0 to 2.50.0 Review Comment: This is actually a lance-ray bug — its `on_write_complete` and `estimate_inmemory_data_size` implementations are incompatible with certain Ray API versions. lance-ray already works around this by pinning `ray[data]>=2.40.0,<=2.52.1` in its own `pyproject.toml` (tracked in https://github.com/lance-format/lance-ray/issues/68). Since the constraint is declared in lance-ray's own dependency, pip will enforce it automatically. Documenting the Ray version range in Gravitino's docs would be redundant and would require Gravitino to track lance-ray's internal bug fixes going forward. Suggesting to remove this line and let lance-ray's own packaging handle it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
