bbiiaaoo commented on code in PR #10637:
URL: https://github.com/apache/gravitino/pull/10637#discussion_r3207141302
##########
lance/lance-common/src/main/java/org/apache/gravitino/lance/common/ops/gravitino/GravitinoLanceNameSpaceOperations.java:
##########
@@ -414,6 +408,56 @@ private <T> T[] buildChanges(
return Stream.concat(setPropertiesStream,
removePropertiesStream).toArray(arrayCreator);
}
+ private static CreateMode parseCreateMode(String instance, String mode) {
+ if (mode == null) {
+ return CreateMode.CREATE;
+ }
+ String normalized = CommonUtil.normalizeToken(mode);
Review Comment:
Good catch. We only need case-insensitive parsing here, not removing special
characters. I updated the normalization to trim and uppercase only, and
malformed values like #CREATE$ will now be rejected.
The table format has been updated as per the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
