sunyuhan1998 commented on code in PR #10895:
URL: https://github.com/apache/gravitino/pull/10895#discussion_r3212901443
##########
lance/lance-rest-server/src/main/java/org/apache/gravitino/lance/service/rest/LanceTableOperations.java:
##########
@@ -90,16 +96,37 @@ public Response describeTable(
DescribeTableRequest request) {
try {
validateDescribeTableRequest(request);
+ boolean vendCredentials =
+ request.getVendCredentials() == null ||
Boolean.TRUE.equals(request.getVendCredentials());
Review Comment:
No, credentials are only injected when the client explicitly sets
`vendCredentials = true` in the request. When `vendCredentials` is not set or
is `false`, `credentialPrivilege` remains `null`, and the code falls into the
`else` branch which returns only the original storage options without any
credentials. See the `if (credentialPrivilege != null)` check in
`GravitinoLanceTableOperations.describeTable()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
