sunyuhan1998 commented on PR #10895: URL: https://github.com/apache/gravitino/pull/10895#issuecomment-4417106557
Apologies for the force push. Here's a summary of the changes in the latest revision based on review feedback: 1. **`LanceTableOperations.java`** — Throw `IllegalArgumentException` when namespace is not 3-level, instead of silently returning `CredentialPrivilege.READ` (per @yuqi1129's suggestion). 2. **`LanceRESTServiceIT.java`** — Fix `org.junit.Assume.assumeTrue` (JUnit 4) to `org.junit.jupiter.api.Assumptions.assumeTrue` (JUnit 5) for the deploy-mode skip guard. 3. **`GravitinoLanceTableOperations.java`** — Add `close()` method to properly close cached `CatalogCredentialManager` instances (resource leak fix). Also moved `ALTER_HANDLERS` (static) before instance fields per code style guidelines. 4. **`GravitinoLanceNamespaceWrapper.java`** — Call `tableOperations.close()` in `close()` to wire up the lifecycle (following the same pattern as Iceberg REST's `CatalogWrapperForREST`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
