yuqi1129 commented on code in PR #11127: URL: https://github.com/apache/gravitino/pull/11127#discussion_r3257391261
########## plugins/idp-basic/src/main/java/org/apache/gravitino/idp/storage/mapper/IdpBaseSQLProviderFactory.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.idp.storage.mapper; + +import com.google.common.collect.ImmutableMap; +import java.util.Map; +import org.apache.gravitino.storage.relational.JDBCBackend.JDBCBackendType; +import org.apache.gravitino.storage.relational.session.SqlSessionFactoryHelper; + +abstract class IdpBaseSQLProviderFactory<T> { + private final T mysqlProvider; + private final T h2Provider; + private final T postgresqlProvider; + private final Map<JDBCBackendType, T> providerMap; + private final String providerName; + + protected IdpBaseSQLProviderFactory( + String providerName, T mysqlProvider, T h2Provider, T postgresqlProvider) { Review Comment: The parameter named `mysqlProvider` here actually receives `new IdpGroupMetaBaseSQLProvider()` / `new IdpUserMetaBaseSQLProvider()` at the call sites — i.e. the **base** class is being passed as the "mysql" slot, not a MySQL-specific subclass. That works because `(UNIX_TIMESTAMP() * 1000.0)` in the base provider happens to be MySQL-flavored, but for a new reader it's surprising: looking at the H2 / PostgreSQL subclasses you naturally expect a `IdpGroupMetaMySQLProvider` next to them and there isn't one. Two ways to make this self-documenting (pick whichever feels less invasive): 1. **Cheap** — rename the constructor parameter to `mysqlOrBaseProvider` (or `mysqlAndDefaultProvider`) and add one javadoc line saying "the base SQL provider is the MySQL provider by convention; H2 / PostgreSQL extend it with backend-specific overrides". 2. **Bigger** — rename `IdpGroupMetaBaseSQLProvider` → `IdpGroupMetaMySQLProvider` (and the user one too), then have an actual `IdpGroupMetaBaseSQLProvider` abstract class without the MySQL-specific default. That makes the constructor call read naturally: `super("...", new IdpGroupMetaMySQLProvider(), new IdpGroupMetaH2Provider(), new IdpGroupMetaPostgreSQLProvider())`. Option 1 is cheap and worth doing here since this base class is now shared by both user and group factories — the confusion compounds once a third subclass shows up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
