lasdf1234 commented on code in PR #11127: URL: https://github.com/apache/gravitino/pull/11127#discussion_r3258501080
########## plugins/idp-basic/src/main/java/org/apache/gravitino/idp/storage/mapper/IdpBaseSQLProviderFactory.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.idp.storage.mapper; + +import com.google.common.collect.ImmutableMap; +import java.util.Map; +import org.apache.gravitino.storage.relational.JDBCBackend.JDBCBackendType; +import org.apache.gravitino.storage.relational.session.SqlSessionFactoryHelper; + +abstract class IdpBaseSQLProviderFactory<T> { + private final T mysqlProvider; + private final T h2Provider; + private final T postgresqlProvider; + private final Map<JDBCBackendType, T> providerMap; + private final String providerName; + + protected IdpBaseSQLProviderFactory( + String providerName, T mysqlProvider, T h2Provider, T postgresqlProvider) { + this.providerName = providerName; + this.mysqlProvider = mysqlProvider; + this.h2Provider = h2Provider; + this.postgresqlProvider = postgresqlProvider; + this.providerMap = + ImmutableMap.of( + JDBCBackendType.MYSQL, + mysqlProvider, + JDBCBackendType.H2, + h2Provider, + JDBCBackendType.POSTGRESQL, + postgresqlProvider); + } + + protected final T h2ProviderInstance() { + return h2Provider; + } + + protected final T mysqlProviderInstance() { + return mysqlProvider; + } + + protected final T postgresqlProviderInstance() { + return postgresqlProvider; + } + + protected final T currentProviderInstance() { + return resolveProvider(currentDatabaseId()); + } + + protected final T resolveProvider(String databaseId) { + if (databaseId == null) { + throw new IllegalStateException( + String.format("MyBatis databaseId is not configured for %s.", providerName)); Review Comment: Got,This is truly an excellent method. It has been revised and the code has become much more concise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
