Copilot commented on code in PR #11060:
URL: https://github.com/apache/gravitino/pull/11060#discussion_r3272365945
##########
lance/lance-rest-server/src/test/java/org/apache/gravitino/lance/service/rest/TestLanceNamespaceOperations.java:
##########
@@ -115,6 +116,7 @@ protected Application configure() {
resourceConfig.property(CommonProperties.FEATURE_AUTO_DISCOVERY_DISABLE,
true);
Review Comment:
This block comment mentions `extractPropertiesFromBody()` as the reason for
disabling Jersey auto-discovery, but that helper was removed along with the
`create-empty` endpoint. Please update the comment to reflect the current
motivation for disabling auto-discovery (or remove it) so the test setup stays
accurate.
##########
clients/client-python/setup.py:
##########
@@ -56,6 +56,7 @@
install_requires=open("requirements.txt").read(),
extras_require={
"dev": open("requirements-dev.txt").read(),
+ "lance": open("requirements-lance.txt").read(),
},
Review Comment:
`extras_require` now reads `requirements-lance.txt`, but
`clients/client-python/MANIFEST.in` only includes `requirements.txt` and
`requirements-dev.txt`. Building/installing from an sdist will fail when that
file is missing. Please add `requirements-lance.txt` to MANIFEST.in (or switch
to inline requirements) so packaging works.
##########
catalogs/catalog-lakehouse-generic/src/main/java/org/apache/gravitino/catalog/lakehouse/lance/LanceTableOperations.java:
##########
@@ -282,14 +282,14 @@ Table createTableInternal(
ident, columns, comment, properties, partitions, distribution,
sortOrders, indexes);
}
- // Check whether it's a create empty table operation.
+ // Check whether it's a metadata-only declare table operation.
boolean createEmpty =
-
Optional.ofNullable(properties.get(LanceConstants.LANCE_TABLE_CREATE_EMPTY))
+
Optional.ofNullable(properties.get(LanceConstants.LANCE_TABLE_DECLARED))
.map(Boolean::parseBoolean)
.orElse(false);
if (createEmpty) {
- // For create empty table, we just create the table metadata in
Gravitino without creating
- // the underlying Lance dataset.
+ // For declare table, we just create the table metadata in Gravitino
without creating the
+ // underlying Lance dataset.
Review Comment:
The boolean `createEmpty` is now derived from `LANCE_TABLE_DECLARED` and
drives the declare-table (metadata-only) flow, so the name is misleading after
the semantics change. Renaming it (e.g., `declaredOnly` / `isDeclared`) will
make the control flow easier to follow and reduce confusion.
##########
lance/lance-common/src/main/java/org/apache/gravitino/lance/common/utils/LanceConstants.java:
##########
@@ -39,7 +39,7 @@ public class LanceConstants {
public static final String LANCE_TABLE_VERSION = "lance.version";
// Mark whether it is to create an empty Lance table(no data files)
Review Comment:
The comment above `LANCE_TABLE_DECLARED` still describes the old
`create-empty` semantics. Please update it to reflect that this flag now
represents a metadata-only *declare table* operation (or remove the outdated
wording) to avoid confusing future maintainers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
