yuqi1129 commented on code in PR #11060:
URL: https://github.com/apache/gravitino/pull/11060#discussion_r3272458285
##########
clients/client-python/setup.py:
##########
@@ -56,6 +56,7 @@
install_requires=open("requirements.txt").read(),
extras_require={
"dev": open("requirements-dev.txt").read(),
+ "lance": open("requirements-lance.txt").read(),
},
Review Comment:
Updated in ee93f7164: added `requirements-lance.txt` to `MANIFEST.in`.
##########
lance/lance-common/src/main/java/org/apache/gravitino/lance/common/utils/LanceConstants.java:
##########
@@ -39,7 +39,7 @@ public class LanceConstants {
public static final String LANCE_TABLE_VERSION = "lance.version";
// Mark whether it is to create an empty Lance table(no data files)
Review Comment:
Updated in ee93f7164: refreshed the comment to describe metadata-only
declare-table semantics.
##########
catalogs/catalog-lakehouse-generic/src/main/java/org/apache/gravitino/catalog/lakehouse/lance/LanceTableOperations.java:
##########
@@ -282,14 +282,14 @@ Table createTableInternal(
ident, columns, comment, properties, partitions, distribution,
sortOrders, indexes);
}
- // Check whether it's a create empty table operation.
+ // Check whether it's a metadata-only declare table operation.
boolean createEmpty =
-
Optional.ofNullable(properties.get(LanceConstants.LANCE_TABLE_CREATE_EMPTY))
+
Optional.ofNullable(properties.get(LanceConstants.LANCE_TABLE_DECLARED))
.map(Boolean::parseBoolean)
.orElse(false);
if (createEmpty) {
- // For create empty table, we just create the table metadata in
Gravitino without creating
- // the underlying Lance dataset.
+ // For declare table, we just create the table metadata in Gravitino
without creating the
+ // underlying Lance dataset.
Review Comment:
Updated in ee93f7164: renamed the local variable to `declaredOnly`.
##########
lance/lance-rest-server/src/test/java/org/apache/gravitino/lance/service/rest/TestLanceNamespaceOperations.java:
##########
@@ -115,6 +116,7 @@ protected Application configure() {
resourceConfig.property(CommonProperties.FEATURE_AUTO_DISCOVERY_DISABLE,
true);
Review Comment:
Updated in ee93f7164: removed the stale `extractPropertiesFromBody`
reference from the test setup comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
