roryqi commented on code in PR #11209:
URL: https://github.com/apache/gravitino/pull/11209#discussion_r3295976153
##########
plugins/idp-basic/src/main/java/org/apache/gravitino/idp/storage/service/IdpGroupMetaService.java:
##########
@@ -70,7 +70,12 @@ public void insertIdpGroup(IdpGroupPO groupPO) {
@Monitored(
metricsSource = GRAVITINO_RELATIONAL_STORE_METRIC_NAME,
baseMetricName = "deleteIdpGroup")
- public boolean deleteIdpGroup(String groupName) {
+ public boolean deleteIdpGroup(String groupName, boolean cascade) {
Review Comment:
cc @jerryshao Prefer not using cascade.
If we use `cascade`, it make users confused.
It usually means that we delete the users in the group.
`cascade` mode means that we need to delete all the children in the
container.
Actually, we just remove the relations user and groups.
My suggestion is to use the word `force`.
The force means that we have some constraints, but we still want to execute
the command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
